[Marble-bugs] [marble] [Bug 345919] New: Bookmark icons use absolute paths in any case

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=345919

            Bug ID: 345919
           Summary: Bookmark icons use absolute paths in any case
           Product: marble
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org

In https://git.reviewboard.kde.org/r/121665 a customization of bookmark icon
paths was added. Now the icon of bookmarks is saved along with the bookmarks
file by specifying an absolute path to the icon image, even for the default
case. There are a couple of downsides with this approach
- if the installation directory is changed e.g. by the distribution, all user
bookmark icons will break
- if we change the path to the default bookmark icon or its name, all user
bookmark icons will break
- there is no support for icons loaded via qrc, which is important e.g. for
diskless systems

I'd suggest an improved version which
- provides a couple of standard bookmark icon variants in a well-known qrc
subfolder. E.g. qrc:/marble/bookmarks/bookmark_red.png,
qrc:/marble/bookmarks/bookmark_yellow.png, ...
- has a list view or similar that displays those icons in the dialog for easy
selection by the user
- optionally allows to insert further user-defined icons which could then use
absolute paths to file system locations

-- 
You are receiving this mail because:
You are the assignee for the bug.