[Marble-bugs] [marble] [Bug 339573] src/lib/astro/eclsolar.cpp:175: possible bad assignment ?

Dennis Nienhüser earthwings at gentoo.org
Thu Oct 2 03:48:42 UTC 2014


https://bugs.kde.org/show_bug.cgi?id=339573

Dennis Nienhüser <earthwings at gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |earthwings at gentoo.org,
                   |                            |rahn at kde.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |CONFIRMED

--- Comment #1 from Dennis Nienhüser <earthwings at gentoo.org> ---
Maybe the real intention is
eb_cstep = max( 0, floor( s ) );
However a value of 0 seems to be problematic later on, I spot a divison by zero
that would follow from that.

The good news is that the corresponding method is never called, i.e. a
candidate for removal altogether. Would still be nice to clear it up with
someone who knows more about the code in question. Torsten, can you chime in,
or follow up with Holger?

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Marble-bugs mailing list