[Marble-bugs] [marble] [Bug 334286] New: Equality operators for Container, Folder and Document

Dennis Nienhüser earthwings at gentoo.org
Sat May 3 16:18:25 UTC 2014


https://bugs.kde.org/show_bug.cgi?id=334286

            Bug ID: 334286
           Summary: Equality operators for Container, Folder and Document
    Classification: Unclassified
           Product: marble
           Version: 1.7 (KDE 4.12)
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Keywords: google-code-in, junior-jobs
          Severity: task
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org
        Depends on: 334285

Override the equals() method in GeoDataContainer. Have it iterate over m_vector
and check each feature for equality by downcasting it to possible children
based on the nodeType(). Possible children are GeoDataDocument, GeoDataFolder,
GeoDataNetworkLinkControl, GeoDataNetworkLink, GeoDataGroundOverlay,
GeoDataPhotoOverlay, GeoDataScreenOverlay, GeoDataPlacemark and GeoDataTour,
see
http://api.kde.org/4.x-api/kdeedu-apidocs/marble/html/classMarble_1_1GeoDataFeature.html

Add operator== and operator!= to GeoDataFolder and GeoDataDocument. For
GeoDataFolder it only needs to return the result of equals() of its parent
GeoDataContainer. For GeoDataDocument additionally the other members need to be
checked.

Extend TestEquality for new unit test methods for GeoDataFolder (no need for a
GeoDataDocument unit test in this task). Make sure to compile Marble with the
BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build
folder (run tests/TestEquality). Submit a review request at
https://git.reviewboard.kde.org.

Please leave a comment here (e.g. "I want to work on this task.") if you start
working on this task to avoid multiple people working on it at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Marble-bugs mailing list