[Marble-bugs] [marble] [Bug 331671] New: Equality operator for GeoDataTour and related classes

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=331671

            Bug ID: 331671
           Summary: Equality operator for GeoDataTour and related classes
    Classification: Unclassified
           Product: marble
           Version: 1.7 (KDE 4.12)
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Keywords: google-code-in, junior-jobs
          Severity: task
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org

Make it possible to check for equality of GeoDataTour instances
- Add operator== to GeoDataAnimatedUpdate, GeoDataSoundCue, GeoDataTourControl
and GeoDataWait
- Add operator== to GeoDataPlaylist. Return false if the size() of the
playlists differ. Otherwise iterate over all primitives and do the following:
If the nodeType of two primitives with the same index differs, return false.
Otherwise cast it to the respective GeoData* class (GeoDataAnimatedUpdate,
GeoDataFlyTo, GeoDataSoundCue, GeoDataTourControl or GeoDataWait) and check
their equality using their operator==.
- Add operator== to GeoDataTour, which checks if the playlists of two Tours are
equal

If bug 331666 is done by the time you work on this, integrate the equals()
method of GeoDataObject into the operator== implementations.

Make sure to compile Marble with the following cmake options enabled:
BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestEquality
and make sure no errors come up. Use tools/kml2kml to analyze errors and fix
the tag writers, if needed. Submit a review request at
https://git.reviewboard.kde.org with the marble group as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start
working on this task to avoid multiple people working on it at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.