[Marble-bugs] [marble] [Bug 331585] New: Change GeoDataObject id and targetId from int to QString

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=331585

            Bug ID: 331585
           Summary: Change GeoDataObject id and targetId from int to
                    QString
    Classification: Unclassified
           Product: marble
           Version: 1.7 (KDE 4.12)
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Keywords: google-code-in, junior-jobs
          Severity: task
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org

Currently the GeoDataObject class has an id and a targetId members, both int.
They need to be QStrings though. Change them and the corresponding
getters/setters.

Adjust PopupLayer.cpp and change
QString::number(placemark->id())
to a simple
placemark->id()
afterwards.

Remove the id member from the following classes: GeoDataTourControl,
GeoDataTour, GeoDataWait, GeoDataSoundCue. Verify that the code still compiles
(the classes will inherit id() from GeoDataObject now) and all unit tests pass.

Make sure to compile Marble with the following cmake options enabled:
BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Submit a review request at
https://git.reviewboard.kde.org with the marble groups as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start
working on this task to avoid multiple people working on it at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.