[Marble-bugs] [marble] [Bug 331470] New: Implement equality comparison of GeoDataAccuracy and GeoDataAlias

Dennis Nienhüser earthwings at gentoo.org
Mon Feb 24 19:13:28 UTC 2014


https://bugs.kde.org/show_bug.cgi?id=331470

            Bug ID: 331470
           Summary: Implement equality comparison of GeoDataAccuracy and
                    GeoDataAlias
    Classification: Unclassified
           Product: marble
           Version: 1.7 (KDE 4.12)
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Keywords: google-code-in, junior-jobs
          Severity: task
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org

Add two methods
bool operator==( const GeoDataAlias &other ) const;
bool operator!=( const GeoDataAlias &other ) const;
operator!= should call !operator== inside its implementation.
to GeoDataAlias which implement equality comparision. Add a new unit test in
tests/ called TestEquality.cpp (make sure to add it to CMakeLists.txt as well)
which creates different GeoDataAlias instances and compares them. Some should
be equal, some different, covering various combinations.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and
run the test case from the build folder (run tests/TestEquality). 

Extend GeoDataAccurary and add a new operator
bool operator!=( const GeoDataAccuracy &other ) const;
which calls the existing operator== in its implementation. Add test cases for
various equal and  unequal instances of GeoDataAccuracy to TestEquality.cpp as
well.

Submit a review request at https://git.reviewboard.kde.org with the marble
groups as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start
working on this task to avoid multiple people working on it at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Marble-bugs mailing list