[Marble-bugs] [marble] [Bug 333117] New: Equality operators for time related classes

Dennis Nienhüser earthwings at gentoo.org
Sun Apr 6 08:43:30 UTC 2014


https://bugs.kde.org/show_bug.cgi?id=333117

            Bug ID: 333117
           Summary: Equality operators for time related classes
    Classification: Unclassified
           Product: marble
           Version: 1.8 (KDE 4.13)
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Keywords: google-code-in, junior-jobs
          Severity: task
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org

Add operator== and operator!= to the classes GeoDataTimeSpan and
GeoDataTimeStamp. Change the protected bool equals method of GeoDataObject to
become virtual, and overwrite it in GeoDataAbstractView. Have its
implementation check the time members and altitude mode. This change will
affect operator== of GeoDataCamera. Make sure that TestEquality still succeeds.
Extend TestEquality by a new unit test method for GeoDataTimeSpan and
GeoDataTimeStamp which verifies the implementation for several instances of
each class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and
run the test case from the build folder (run tests/TestEquality). Note that
operator!= should call operator==, see GeoDataAccuracy for an example. Submit a
review request at https://git.reviewboard.kde.org.

Please leave a comment here (e.g. "I want to work on this task.") if you start
working on this task to avoid multiple people working on it at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Marble-bugs mailing list