[Marble-bugs] [marble] [Bug 333116] New: Equality operators for overlay related classes

Dennis Nienhüser earthwings at gentoo.org
Sun Apr 6 08:28:30 UTC 2014


https://bugs.kde.org/show_bug.cgi?id=333116

            Bug ID: 333116
           Summary: Equality operators for overlay related classes
    Classification: Unclassified
           Product: marble
           Version: 1.8 (KDE 4.13)
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Keywords: google-code-in, junior-jobs
          Severity: task
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org

Add operator== and operator!= to the classes GeoDataViewVolume, GeoDataVec2,
GeoDataScreenOverlay, GeoDataPhotoOverlay and GeoDataGroundOverlay. Add a
protected bool equals( const GeoDataOverlay &other ) const method to
GeoDataOverlay which is called in operator== of GeoDataScreenOverlay,
GeoDataPhotoOverlay and GeoDataGroundOverlay to avoid redundancy. Extend
tests/TestEquality by a new unit test method for each of the classes (except of
GeoDataOverlay) which verifies the implementation for several instances of each
class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and
run the test case from the build folder (run tests/TestEquality). Note that
operator!= should call operator==, see GeoDataAccuracy for an example. Submit a
review request at https://git.reviewboard.kde.org.

Please leave a comment here (e.g. "I want to work on this task.") if you start
working on this task to avoid multiple people working on it at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Marble-bugs mailing list