[Marble-bugs] [marble] [Bug 316561] New: Crash when tile image height does not match specified height in DGML file

[Rolf Eike Beer]

https://bugs.kde.org/show_bug.cgi?id=316561

            Bug ID: 316561
           Summary: Crash when tile image height does not match specified
                    height in DGML file
    Classification: Unclassified
           Product: marble
           Version: 1.5.0 (KDE 4.10.0)
          Platform: openSUSE RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: kde at opensource.sf-tec.de

I created my own DGML file, which had the image dimensions (in this case
height) set wrongly. But the same error may also happen if a tile downloaded
from the server is somehow damaged. The crash happens in line 97
ofStackedTilePrivate::pixel():

    if ( m_depth == 32 )
>>        return (jumpTable32)[y][x];

The problem is that jumpTable32 is initialized by jumpTableFromQImage32() with
img.height(), so if the image has smaller than the expected height than this
access will go into nowhere, leading to a crash.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.