[Marble-bugs] [marble] [Bug 317792] New: Improve the download progress API

[Dennis Nienhüser]

https://bugs.kde.org/show_bug.cgi?id=317792

            Bug ID: 317792
           Summary: Improve the download progress API
    Classification: Unclassified
           Product: marble
           Version: 1.6.0 (KDE 4.11.0)
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: task
          Priority: NOR
         Component: general
          Assignee: marble-bugs at kde.org
          Reporter: earthwings at gentoo.org

Currently jobs added to and removed from the download queue when downloading
map tile images fire a jobAdded and jobRemoved signal, respectively. These
signals are used to report download progress in the progress dialog and
download progress float item. There are two problems:
- Some signals seem to be missing, maybe when downloads time out. This means
that at times the progress report is not accurate
- The signal/slot connections depend on the visibility of the progress report
widget. If the queue is not empty when the progress report widget becomes
visible, the progress report is not accurate

To fix this, add a new signal like downloadProgressChanged(int done, int
running, int queued). Maintain the associated counts (including setting done to
0 at appropriate times, e.g. when running and queued are 0). Connect the
progress report widgets to the new signal. Make sure that the download progress
report in the progress bar behaves in a sane way.

-- 
You are receiving this mail because:
You are the assignee for the bug.