[Marble-bugs] [Bug 309273] Marble crashes when --smallscreen is specified and no local bookmark folder exists

Bernhard Beschow bbeschow at cs.tu-berlin.de
Wed Oct 31 19:40:41 UTC 2012


https://bugs.kde.org/show_bug.cgi?id=309273

Bernhard Beschow <bbeschow at cs.tu-berlin.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/marb
                   |                            |le/9e630ca10ce4fa175a63dfc7
                   |                            |a4e9cda2b73cba4f

--- Comment #1 from Bernhard Beschow <bbeschow at cs.tu-berlin.de> ---
Git commit 9e630ca10ce4fa175a63dfc7a4e9cda2b73cba4f by Bernhard Beschow.
Committed on 31/10/2012 at 17:53.
Pushed by beschow into branch 'master'.

always create an empty bookmark document upon construction

Establishing the invariant that a document is always around avoids null pointer
issues. In addition, creating an empty document upon construction should be
indistinguishable from outside (compared to the previous approach where a
document is created on demand).

M  +4    -12   src/lib/BookmarkManager.cpp
M  +1    -1    src/lib/BookmarkManagerDialog.cpp
M  +0    -2    src/lib/BookmarkManager_p.h
M  +8    -25   tests/BookmarkManagerTest.cpp

http://commits.kde.org/marble/9e630ca10ce4fa175a63dfc7a4e9cda2b73cba4f

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Marble-bugs mailing list