[Marble-bugs] [Bug 241125] Win32: compilation fails for aprs plugin

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=241125

Pino Toscano <pino at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/marb
                   |                            |le/f8ea7ba60fa3d3bca313e1c3
                   |                            |b440ed7173245cc8

--- Comment #8 from Pino Toscano <pino at kde.org> ---
Git commit f8ea7ba60fa3d3bca313e1c3b440ed7173245cc8 by Pino Toscano.
Committed on 30/11/2012 at 19:09.
Pushed by pino into branch 'master'.

aprs: use external QextSerialPort for TTY reading

Instead of embedding an (old) copy of the QextSerialPort library, find for an
external one;
only if found enable the reading from TTY, which is otherwise disabled (leaving
its configuration tab disabled).

The drop of the internal QextSerialPort should also fix all the portability
issues,
since the plugin itself does not use any OS-dependent API, and it is then
reenabled unconditionally.
Hence,
Related: bug 237931, bug 242039
should now be fixed, and
should not happen anymore.

REVIEW: 107536

A  +16   -0    cmake/modules/FindQextSerialPort.cmake
M  +1    -3    src/plugins/render/CMakeLists.txt
M  +17   -2    src/plugins/render/aprs/AprsPlugin.cpp
M  +2    -1    src/plugins/render/aprs/AprsTTY.cpp
M  +10   -13   src/plugins/render/aprs/CMakeLists.txt
M  +2    -2    src/plugins/render/aprs/aprsconfig.h.in
D  +0    -979  src/plugins/render/aprs/posix_qextserialport.cpp
D  +0    -262  src/plugins/render/aprs/qextserialport.cpp
D  +0    -338  src/plugins/render/aprs/qextserialport.h
D  +0    -21   src/plugins/render/aprs/qextserialport_global.h
D  +0    -874  src/plugins/render/aprs/win_qextserialport.cpp

http://commits.kde.org/marble/f8ea7ba60fa3d3bca313e1c3b440ed7173245cc8

-- 
You are receiving this mail because:
You are the assignee for the bug.