[Marble-bugs] [Bug 282394] Drop the leftclick menu

[Bernhard Beschow]

https://bugs.kde.org/show_bug.cgi?id=282394


Bernhard Beschow <bbeschow at cs.tu-berlin.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Bernhard Beschow <bbeschow cs tu-berlin de>  2011-11-24 19:37:53 ---
Git commit 0613cbb9dd4d3db3a5d6963c938221ab9bd7b03c by Bernhard Beschow.
Committed on 06/11/2011 at 00:19.
Pushed by beschow into branch 'master'.

rework lmb and rmb menus

The lmb as well as the rmb menu used to offer actions regarding the current geo
position. In particular, the lmb menu offers "Copy
Coordinates" and "Address Details", while the rmb menu offers "Add Bookmark"
and "Set Home Location". As a result, neither of the
menus have precise duties, creating ambiguities, which this patch addresses as
described below.

The lmb menu is now only responsible for dealing with links of geo features (in
analogy to a web browser): When the mouse cursor
hovers above a feature (indicated by turning into an pointing hand), then a lmb
click will reveal the lmb menu. If the mouse is not a
pointing hand, no lmb menu will appear when clicking the left mouse button.

No other actions than geo feature actions are part of the lmb menu. In
particular, the unimplemented "planet" action is removed
entirely, whereas the remaining actions basically went into the rmb menu.

The rmb menu's purpose is to provide context actions for the respective geo
position. It can be triggered anywhere and anytime
above the map (mouse cursor above a valid geo position).
Since the "Add Bookmark" and even more so the "Set Home Location" actions are
believed to be very rarely used, they are removed in the
desktop version (but they are still available from the application menu). The
mobile version keeps the "Add Bookmark" action, but
the "Set Home Location" is removed as well.
The "Copy Coordinates" and "Address Details" actions (removed from the lmb
menu) are both moved to the rmb menu in the desktop version.
The mobile version gains the "Address Details" action.

BUG: 282394
REVIEW: 103053
GUI

M  +24   -44   src/lib/MarbleWidgetPopupMenu.cpp
M  +0    -3    src/lib/MarbleWidgetPopupMenu.h

http://commits.kde.org/marble/0613cbb9dd4d3db3a5d6963c938221ab9bd7b03c

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.