Some issues with project plugin ?

[Christoph Cullmann (cullmann.io)]

On 2023-01-25 00:52, Alexander Neundorf wrote:
> On Montag, 23. Januar 2023 23:42:41 CET Alexander Neundorf wrote:
>> Hi,
>> 
>> are there any known issues with the project plugin ?
>> I haven't investigated yet, but here is what I see:
>> it looks like, that even though in the .kateproject file, the "files" 
>> entry
>> is not empty, but contains a long list of files, kate doesn't seem to 
>> know
>> about any files in that project. Is it possible that the "list" mode 
>> is
>> broken ?
> 
> It is indeed broken.
> 
> In void KateProjectWorker::loadFilesEntry(), "fullFilePath" is set like 
> this:
>             fullFilePath = dirPath + filePath;
> 
> without checking whether filePath is already an absolute path.
> So if the list of files in the kateproject file already contains 
> absolute paths,
> the base directory is prepended to those absolute paths, which results 
> in bad
> paths.
> 
> I could check QFileInfo::isAbsolute(), but the comment says that's too 
> slow.
> If nobody else is faster, I'll do something in the next days.

If we only do that for the case that the user did explicit file 
specification
in the .kateproject, speed should be no issue, that is only relevant for 
the git/...
cases that generate file lists.

> 
> Alex

-- 
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org