Filtering also matches the filenames...

[Waqar Ahmed]

Also, I think using a single character for filtering is just unrealistic,
and using it to test the filter quality is imo not useful. With a few more
characters or a word, the filter will work better.

On Mon, Mar 7, 2022, 11:29 PM Alexander Neundorf <neundorf at kde.org> wrote:

> Hi,
>
> the filtering currently also matches the filenames, and that using their
> full
> path.
> This leads to strange behaviour.
> I typed "x" in the filter, and everything was still visible, although
> there
> was no "x" anywhere.
> I found that the filter "x" matched them all because they were all in some
> subdir of my home directory "/home/alex/", which contains an "x".
> In my local copy I changed it so that fileToPlainText() removes the base
> directory from the filtering, so that only that part of the filename is
> matched that is also displayed in the results.
>
> But that still is strange. If I now enter something that occurs in all
> found
> filenames, but not in any actual match, the results list now tells me
> "0 matched (0 checked)" but still displays all search results and all of
> them
> are checked.
>
> How about applying the filtering only to the actual contents of the files,
> and
> ignore the filenames completely ?
>
> Alex
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20220308/07cc01d9/attachment.htm>