D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

Benjamin Wuethrich noreply at phabricator.kde.org
Thu May 14 05:07:35 BST 2020


bewuethr created this revision.
bewuethr added a reviewer: Framework: Syntax Highlighting.
bewuethr added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
bewuethr requested review of this revision.

REVISION SUMMARY
  When the PostgreSQL syntax definition file was converted from using named attributes and contexts instead of numbers in this commit <https://invent.kde.org/kde/kate/-/commit/2e55bd0ca7deaaffe5546f04e2925112cca2a9a6#5d04d3f12b2774e3618e339c318f3154ac45df03>, the attribute for an opening double quote was incorrectly set to `"Comment"` instead of `"Identifier"`. This patch fixes that.
  
  BUG: 421445

TEST PLAN
  Incorrect opening double quote before fix:
  
  F8318517: Screenshot from 2020-05-14 00-00-30.png <https://phabricator.kde.org/F8318517>
  
  Correct opening double quote after fix:
  
  F8318530: Screenshot from 2020-05-14 00-06-41.png <https://phabricator.kde.org/F8318530>

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

AFFECTED FILES
  data/syntax/sql-postgresql.xml

To: bewuethr, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200514/10cd41a5/attachment.htm>


More information about the KWrite-Devel mailing list