D25339: update lineHeight if boundingRect indicates a larger value.

Dominik Haumann noreply at phabricator.kde.org
Sat May 9 16:48:27 BST 2020


dhaumann added a comment.


  In D25339#666832 <https://phabricator.kde.org/D25339#666832>, @cullmann wrote:
  
  > Looking at the code, might it make more sense to just move away from the fixed height we have?
  
  
  Yes please. Instead of hacks and options, which will make the code and the UI harder to use, the correct fix is to switch to variable line heights.
  
  Of course you need to touch many places, but this approach is so much better than hacks. Please give it a try! :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200509/93302af2/attachment.htm>


More information about the KWrite-Devel mailing list