D28039: optimize dynamic regex matching

Dominik Haumann noreply at phabricator.kde.org
Fri Mar 13 21:48:30 GMT 2020


dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess this is OK, but the concept of a "skip offset" is a bit fuzzy to me.

INLINE COMMENTS

> rule_p.h:126
> +
> +protected:
> +    bool m_dynamic = false;

I dislike this protected hack :-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200313/f1a71925/attachment.html>


More information about the KWrite-Devel mailing list