D26811: Fix crash in variable expansion (used by external tools)

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  findClosing() is already called with +2 to account for the
  starting %{ characters. So we start at the given pos and
  increment it only after the while loop. Unbalanced cases
  of '{' and '}' are now also unit tested.

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-variable-expansion

REVISION DETAIL
  https://phabricator.kde.org/D26811

AFFECTED FILES
  autotests/src/variable_test.cpp
  src/utils/katevariableexpansionhelpers.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200121/ed6c690d/attachment.html>