D26620: Do not assume that list of documents is non-empty
Kåre Särs
noreply at phabricator.kde.org
Mon Jan 13 11:13:30 GMT 2020
sars accepted this revision.
sars added inline comments.
INLINE COMMENTS
> plugin_search.cpp:1099
> + KTextEditor::View *activeView = m_mainWindow->activeView();
> + if (activeView) documents << activeView->document();
> addHeaderItem();
I would format the "if" like this even if it is only one line.
if () {
foo;
}
It is easier to set a breakpoint in a debugger...
REPOSITORY
R40 Kate
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26620
To: tfry, cullmann, sars
Cc: sars, kwrite-devel, rrosch, domson, michaelh, ngraham, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200113/10a37429/attachment.html>
More information about the KWrite-Devel
mailing list