D26560: Fix selection printing

Robert Hoffmann noreply at phabricator.kde.org
Fri Jan 10 13:40:20 GMT 2020


hoffmannrobert created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Printing selected text only worked correctly if the lines from which text was
  selected fit into single printed lines. Text selected from lines using multiple
  printed lines was printed incompletely and/or additional text which wasn't
  selected was printed.
  
  This patch fixes printing text from long lines.
  
  BUG: 415570

TEST PLAN
  1. Select text from one or more lines which do not fit into single printed lines.
  2. Print (Ctrl+P)
  3. Options: Print range: Selection; Print (preferably to a PDF file)
  4. Compare printed and selected text.
  5. Repeat steps 1 to 4: select and print different parts of the text. For example, first select all, then exclude text from selection from the end, then from the beginning, then from both end and beginning and reduce the selection gradually.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix_selection_printing

REVISION DETAIL
  https://phabricator.kde.org/D26560

AFFECTED FILES
  src/printing/printpainter.cpp

To: hoffmannrobert
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200110/75167125/attachment.html>


More information about the KWrite-Devel mailing list