D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Kate, KDevelop.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Symbols used for marks can be used in different sizes, e.g. depending of the
  line height, to which the icon border adapts, or for the context menu on
  actions to toggle those marks. Being limited to set a single pixmap as
  symbol for a mark results can result in badly scaled symbols being
  displayed.
  Switching to QIcon as dynamic pixmap provider for markers improves this.
  
  For backward compatibility QIcon & QPixmaps are converted into each other in
  case APIs are used mixed.
  
  Currently this is WIP as KDevelop as user of the mark interfaces partially
  relies on providing a single pixmap only, and while taking the pixmaps from
  QIcons does some QIcon::Mode-based rendering (for breakpoints, marking
  disabled, reached, pending or normal ones) or color-tinting (marking line
  removal/addition in patch display with positive & negative colors) before
  passing the pixmaps on. I am not yet sure whether to
  a) turning all those processings into explisit separate dedicatd icons
  
    (my favourite)
  
  b) adding some additional rendering flags to marks
  is the best approach.
  
  If going for a), this patch would be final as is.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/include/ktexteditor/markinterface.h
  src/search/katesearchbar.cpp
  src/view/kateviewhelpers.cpp

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200220/c20969c3/attachment.html>