D27180: Add sortable columns to session manager dialog, and remove previous sorting code
Raphael Rosch
noreply at phabricator.kde.org
Wed Feb 5 21:57:43 GMT 2020
rrosch created this revision.
rrosch added a reviewer: Kate.
rrosch added a project: Kate.
Herald added a subscriber: kwrite-devel.
rrosch requested review of this revision.
REVISION SUMMARY
I really like the new session manager dialog (session chooser) but when I went to click on the column headers to sort, it didn't work. So I wondered how hard it would be to implement and just went for it.
I know the diff is supposed to be done with arc, but I don't yet have that all set up, and I wanted to get you the patch over as soon as possible. I hope that's ok.
One thing that does not work properly is the sorting by number of open files, since that requires numeric sort which was beyond my current abilities, maybe someone else can take that up for the next round, once this simple patch is in.
I also corrected a couple spelling mistakes, which accounts for the extra lines.
TEST PLAN
Apply patch (should apply cleanly to most recent master).
Compile.
Run kate.
REPOSITORY
R40 Kate
REVISION DETAIL
https://phabricator.kde.org/D27180
AFFECTED FILES
kate/session/katesessionchooseritem.h
kate/session/katesessionmanagedialog.cpp
kate/session/katesessionmanagedialog.h
kate/session/katesessionmanagedialog.ui
To: rrosch, #kate
Cc: kwrite-devel, rrosch, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20200205/77bc1ebd/attachment.html>
More information about the KWrite-Devel
mailing list