D24210: KadeModeMenuList: fix memory leaks and others

Nibaldo González noreply at phabricator.kde.org
Thu Sep 26 06:15:41 BST 2019


nibags added a comment.


  `m_searchName` is a pointer to an attribute of a KateFileType object (which may be the string `translatedName` or `name`), but in some cases a new string is created.
  
  I added the boolean `m_bHasNewSearchName` that is true when a new QString is created for search. This is much simpler.
  
  Still, if you don't like it and prefer to use inline attributes, I can change it without problems =)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24210

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190926/19238bb7/attachment.html>


More information about the KWrite-Devel mailing list