Translating External Tools

[Dominik Haumann]

Hi everyone,

I have some translation-related questions for the external tools plugin.
Currently some things are certainly wrong.

1. Messages.sh
We have default tools in a file compiled into Kate, see:
https://invent.kde.org/kde/kate/blob/master/addons/externaltools/defaultexternaltoolsrc
In short, this is a ini-like file. Entries that need translation are:
name=...
category=...
The rest must not be translated. Still, I am pretty sure we are missing a
line or so in the Message.sh extraction script:
https://invent.kde.org/kde/kate/blob/master/addons/externaltools/Messages.sh

Can one of you clarify how to do this properly?

2. ui.rc
The xmlgui file is located here:
https://invent.kde.org/kde/kate/blob/master/addons/externaltools/ui.rc
The contents to be discussed is:
<gui name="externaltools" library="externaltoolsplugin" version="1">

In other plugins, I can also find an attribute "translationDomain", e.g.:
https://invent.kde.org/kde/kate/blob/master/addons/lspclient/ui.rc

My CMakeLists.txt file located at
https://invent.kde.org/kde/kate/blob/master/addons/externaltools/CMakeLists.txt
contains this:
target_compile_definitions(externaltoolsplugin PRIVATE
TRANSLATION_DOMAIN="kateexternaltoolsplugin")

Am I missing the translationDomain in the ui.rc file?

Any hints are welcome.

Best regards
Dominik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190923/5381e73b/attachment.html>