D23824: Initial start of variables dialog

Dominik Haumann noreply at phabricator.kde.org
Tue Sep 10 11:02:55 BST 2019


dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This patch adds one public function to KTextEditor::Editor:
  
    void addVariableExpansion(const QVector<QWidget*>& widgets,
                              const QStringList& variables = QStringList()) const;
  
  Once called for QLineEdits (QTextEdit support still pending),
  QLineEdits will get an action that opens an variable expansion
  dialog that allows the user to insert variables from a list
  view.
  
  What is still missing:
  
  - add support for QTextEdits
  - use for backup prefix/suffix (bug 403583)
  - use in External Tools plugin (bug 299248)

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  add-variables-dialog

REVISION DETAIL
  https://phabricator.kde.org/D23824

AFFECTED FILES
  src/CMakeLists.txt
  src/include/ktexteditor/editor.h
  src/utils/kateglobal.cpp
  src/utils/kateglobal.h
  src/utils/katemacroexpander.cpp
  src/utils/katemacroexpander.h
  src/utils/katevariableexpansionhelpers.h
  src/utils/katevariableexpansionmanager.cpp
  src/utils/katevariableexpansionmanager.h
  src/utils/ktexteditor.cpp
  src/utils/variable.cpp
  src/utils/variable.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190910/995306d3/attachment.html>


More information about the KWrite-Devel mailing list