D23703: (others): Port away from foreach loops over members without calls to owner
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Sep 3 14:57:03 BST 2019
kossebau created this revision.
kossebau added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.
REVISION SUMMARY
There is some small risk here:
- overseen call chains which still call the owner and modify the container
- other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy
GIT_SILENT
REPOSITORY
R39 KTextEditor
BRANCH
portawayfromforeachforitemconstructionestimation_others
REVISION DETAIL
https://phabricator.kde.org/D23703
AFFECTED FILES
src/render/katelayoutcache.cpp
src/schema/kateschemaconfig.cpp
src/script/katescriptmanager.cpp
src/search/katematch.cpp
src/spellcheck/ontheflycheck.cpp
src/variableeditor/variablelistview.cpp
To: kossebau, #kate
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190903/eee47b9a/attachment.html>
More information about the KWrite-Devel
mailing list