D23688: Allow customizing theme attributes in KSyntaxHighligting themes

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  The diff D23516 <https://phabricator.kde.org/D23516> introduce a regression: it isn't possible to customize the bold, italic, underline and strikeout attributes from the settings (Settings > Configure Kate... > Fonts & Colors > Default Text Styles), for KSyntaxHighligting themes.
  
  By using `format.isValid()`, the attributes of the KSyntaxHighligting theme are being overwritten to the theme already applied by KTextEditor and to the theme customizations by the user.
  
  The `format.isValid()` verification is removed, only the attributes set in the syntax definition files are applied.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-attributes

REVISION DETAIL
  https://phabricator.kde.org/D23688

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190903/3485dc32/attachment.html>