D24403: Small performance improvements suggested by clang-tidy
Albert Astals Cid
noreply at phabricator.kde.org
Fri Oct 4 22:49:23 BST 2019
aacid requested review of this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Ok, i'll commit it then :)
> cullmann wrote in modebase.cpp:333
> Hmm, given that is a local var on the stack, I don't see an issue with this.
> This would only be problematic with some static var, or?
right is a local var ^_^ i got confused by a similar-ish patch in qtbase where the qregexp was passed in.
To: aacid, cullmann, dhaumann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel