D25411: Search for KF5I18n and KF5DocTools
Heiko Becker
noreply at phabricator.kde.org
Tue Nov 19 19:51:00 GMT 2019
heikobecker created this revision.
heikobecker added reviewers: Kate, cullmann.
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.
heikobecker requested review of this revision.
REVISION SUMMARY
KF5I18n is required anyway. If it isn't searched and found when the
ki18n_install call, which is injected by the release scripts, is
encountered the build will fail with "CMake Error: No script
specified for argument -P" because a variable usually set by
ki18n_install is not defined.
The same applies to KF5DocTools and kdoctools_install as well, but
it is guarded by a "if (KF5DocTools_FOUND)" so it doesn't error out
but just doesn't install any handbooks, even if KF5DocTools is found.
TEST PLAN
The 19.11.80 tarball builds fine with the patch applied
REPOSITORY
R40 Kate
REVISION DETAIL
https://phabricator.kde.org/D25411
AFFECTED FILES
CMakeLists.txt
To: heikobecker, #kate, cullmann
Cc: kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20191119/b2d7f6f5/attachment.html>
More information about the KWrite-Devel
mailing list