D21409: KWrite: Implement sceleton KTextEditor::Application
Méven Car
noreply at phabricator.kde.org
Mon May 27 09:50:15 BST 2019
meven added inline comments.
INLINE COMMENTS
> kwriteapplication.cpp:80
> +{
> + QList<KWrite *>::iterator i;
> + foreach(KWrite *w, m_windows) {
Unused I believe.
> kwriteapplication.cpp:81
> + QList<KWrite *>::iterator i;
> + foreach(KWrite *w, m_windows) {
> + if (!w->close()) {
Avoid foreach, you can use for future proofing :
for (KWrite *w: qAsConst(m_windows)) {
Reference:
https://www.kdab.com/goodbye-q_foreach/
REPOSITORY
R40 Kate
REVISION DETAIL
https://phabricator.kde.org/D21409
To: michalhumpula, cullmann
Cc: meven, anthonyfieroni, loh.tar, dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190527/63be4737/attachment-0001.html>
More information about the KWrite-Devel
mailing list