D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

Dominik Haumann noreply at phabricator.kde.org
Mon May 20 06:31:21 BST 2019


dhaumann added a comment.


  @cullmann I don't see how we can optimize unneed `hasXXX` calls away: `Format::isDefaultTextStyle(const Theme &theme)` internally uses the same 'hasXXX' calls, i.e. if we use both, we do it twice. Right now I don't see a trivial way to improve the patch.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21295

To: dhaumann, vkrause, cullmann, kossebau
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190520/00f6bb45/attachment.html>


More information about the KWrite-Devel mailing list