D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann, kossebau.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  QTextDocument seems to use the widget palette (or application
  palette) when drawing text. That is, by default the palette's
  foreground color is used when no special QTextCharFormat is
  specified.
  
  This patch changes applyFormat() such that the foreground color
  is always set to avoid the fallback to the QPalette's foreground
  color.
  
  BUG: 406821
  BUG: 406816
  FIXED-IN: 5.59

TEST PLAN
  make && make test + manual testing with the codeeditor example

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-syntax-highlighter-default-color

REVISION DETAIL
  https://phabricator.kde.org/D21295

AFFECTED FILES
  examples/codeeditor.cpp
  src/lib/syntaxhighlighter.cpp

To: dhaumann, vkrause, cullmann, kossebau
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190519/13a702f1/attachment-0001.html>