D21287: Try to find always an unique visible document name without a number suffix

Christoph Cullmann noreply at phabricator.kde.org
Sun May 19 14:15:02 BST 2019

cullmann added a comment.

  I like the idea of having better short document names without numbers.
  The algo looks a bit like what the document list tries to do with the shortest paths differentiating two files.
  I think the documents stuff ignores the changed doc names as it looks for file name changes, but that might be wrong.
  For the code: I would prefer that one uses e.g. just a call to an algorithm for reversing: https://en.cppreference.com/w/cpp/algorithm/reverse
  For the data structures, please use some vector for the pairs, the QList will heap allocate all stuff larger than a pointer.

  R39 KTextEditor


To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190519/4b1ac25a/attachment.html>

More information about the KWrite-Devel mailing list