D19691: [WIP] ViewInternal: Review drop event

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Fix wrong selection when text is moved down
  - Allow drop into own area, but is only noticable when copy, not move
  - Code looks simpler, I think
  
  - Autotest looks good
  - Please see (and comment) code comments
  
  TODO/Help is appreciated
  
  - Cursor is wrong placed after undo
  - Block mode after selection is buggy when mixed tab+spaces are involved
  - Rename some variables, like targetCursor/2

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19691

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190311/1e932a46/attachment.html>