D19511: ViewPrivate: Disable read-only mode action when doc is modified

[loh tar]

loh.tar added a comment.


  So, then I assume you would be pro this patch.
  
  I notice one behavior that would be against this patch but not pro the meaning of "Read Only Mode". When you set this setting and issue a save request you get the "Save as" dialog. Such behavior is good in any case. But such option, working as the current one, should then be called like, "Don't Overwrite File".
  
  When you open as normal user a not writeable file, like /etc/fstab, I would somehow expect to see some warning and/or to enter the "Read Only Mode". But that's not the case. When you issue a save request you will be promted for admin rights, which is good in that example, no doubts.
  
  Then exist the case that an "dangerous/odd" file, e.g. with too long lines, will set to "Read Only Mode". So far I remember is that also only be done to protect the orig file to be overwritten, but not for some hard needs which couldn't be handled by KTextEditor, it's more some odd protection against bad edit performance. So here is also a "Don't Overwrite File" setting more needful at the long end.
  
  So, have have the feeling "Read Only Mode" should be renamed and this patch trashed, and the lock icon patch presumably too :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190310/5fa21ce8/attachment.html>