D19532: Don't crash when no contexts are present

Christoph Cullmann noreply at phabricator.kde.org
Thu Mar 7 08:53:25 GMT 2019

cullmann added a comment.

  I the unit test is separated, no longer all things will be tested with the invalid definitions.
  In D19532#426268 <https://phabricator.kde.org/D19532#426268>, @dhaumann wrote:
  > Could you change the unit test please to not mix with the other ones?
  > - add a new void testBrokenDefinition()
  > - use a local Repository repo;
  > - add custom search oath to this repo
  > - and then check only the broken file.
  >   This would be much cleaner and better to understand & maintain. Maybe even put broken.xml into autotest/input/syntax/broken/
  Hmm, I disagree: then not all functions are tested with a broken file in the repo.

  R216 Syntax Highlighting


To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190307/1ec6a32a/attachment.html>

More information about the KWrite-Devel mailing list