D19532: Don't crash when no contexts are present
noreply at phabricator.kde.org
Wed Mar 6 17:17:23 GMT 2019
vkrause added a comment.
In D19532#425432 <https://phabricator.kde.org/D19532#425432>, @cullmann wrote:
> Ok with that.
> Volker, ok, too?
> I think the if(...isLoaded) removal is a diff artifact, that was never in the original code bug just in the first try here.
Yep, replacing the assert certainly makes sense. This would assume though that the caller of initalContext() expects a nullptr return value already, which I guess is the case if this doesn't crash somewhere else now :)
R216 Syntax Highlighting
To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel