D19532: Don't crash when no contexts are present

Christoph Cullmann noreply at phabricator.kde.org
Tue Mar 5 19:21:21 GMT 2019

cullmann added a comment.

  In D19532#425384 <https://phabricator.kde.org/D19532#425384>, @davispuh wrote:
  > In D19532#425381 <https://phabricator.kde.org/D19532#425381>, @cullmann wrote:
  > > Calling the ::get is no issue.
  > That's good then, but we can't use `applyFormat(0, text.size(), Format());` because Kate asserts when `!Format->isValid()` which it won't be so we have to  `return State();` and also see D19533 <https://phabricator.kde.org/D19533>
  :=) I guess we just need to if (!format.isValid()) return; in the KTextEditor code, seems I didn't read the docs of applyFormat, it just works by chance ATM as I filter out !isValid() definitions there ATM.

  R216 Syntax Highlighting


To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190305/f0f127cd/attachment-0001.html>

More information about the KWrite-Devel mailing list