D19532: Don't crash when no contexts are present

Christoph Cullmann noreply at phabricator.kde.org
Tue Mar 5 05:51:15 GMT 2019


cullmann added a comment.


  Hi, first: good thing to get this fixed, yes, it shall not crash.
  
  For the fix: Wouldn't it be enough to just change the
  
  if (!d->m_definition.isValid()) {
  
    applyFormat(0, text.size(), Format());
  
  ‚Äč  ...
  
  shortcut to check for
  
  if (!d->m_definition.isValid() || defData->isLoaded()) {

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190305/1aecac99/attachment-0001.html>


More information about the KWrite-Devel mailing list