D18793: Handle text completion with block selection mode

Christoph Cullmann noreply at phabricator.kde.org
Mon Mar 4 18:35:01 GMT 2019

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.

  I don't like the change to call typeChars.
  1. that needs a valid view, activeView() might be null.
  2. replaceText is not interactive per-default, but typeChars is.
  And yes, a test would be wanted I think,too.

  R39 KTextEditor


To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff
Cc: loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190304/481c5b47/attachment-0001.html>

More information about the KWrite-Devel mailing list