D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

[Christoph Cullmann]

cullmann added a comment.


  :=) Perhaps I read this diff to fast, but I can not really tell if it does what it should.
  
  I can understand from the description it tries to keep auto-wrapped things in balance during editing.
  
  I think to better understand the behavior, one needs to have tests for the different cases it kicks in.
  
  For the implementation: I think that code shall not be triggered ever if the user has the static wrap off, I think that would be very confusing.
  
  I am even not sure if that should be the default behavior or if one should not be able to turn that off to have a "dumb" but deterministic wrapping.
  
  But I use static word wrap "never", therefore I might be off with my opinion.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19131

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190304/ea03b846/attachment.html>