D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J.V. Bertin]

rjvbb added a comment.


  >   Just load the XML file from bug 404713.
  >   Before this changes here, you did overpaint the next line randomly with the "oversized one", now you "cut" the oversized line.
  
  I don't know where to look specifically in that huge file. I do notice that with the partially reverted commit some lines are very close to one another, possibly even certain glyphs being superimposed, and on certain of those lines the cursor gets decorated by what looks to be a '>'.
  
  What I do NOT see is lines being painted over by whitespace, which is worse in terms of readability.
  
  > Bug 328837 - Add configurable line height to katepart
  
  Apparently,
  
  > There's a problem, though: selection gets inconsistent.
  
  I haven't checked if that's the case (nor if the patch still applies).
  
  The idea is good though, and I'm a bit surpised that there could be problems with it given that KTE already determines the lineheight to use (and changing the way that's hardcoded doesn't lead to selection problems).
  
  You could even make that lineheight scale factor a per-document setting (I could easily imagine someone wanting lines to be more separated in code than in prose, for instance).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190301/572e648f/attachment.html>