D21940: Make automatic spellcheck work after reloading a document

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  You don't need the extra function. Could you update the patch?

INLINE COMMENTS

> ontheflycheck.cpp:75
>  
> +    connect(document, &KTextEditor::Document::reloaded,
> +            this, &KateOnTheFlyChecker::slotDocumentReloaded);

Directly connect to this, refreshSpellCheck.

> ontheflycheck.h:71
>  
> +    void slotDocumentReloaded(const KTextEditor::Document *view = nullptr);
> +

Please delete this function complete, see next comment.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21940

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: dhaumann, sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190621/a54d323b/attachment.html>