D21563: Fix empty pages in print preview and lines printed twice
Robert Hoffmann
noreply at phabricator.kde.org
Mon Jun 3 16:07:09 BST 2019
hoffmannrobert created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
hoffmannrobert requested review of this revision.
REVISION SUMMARY
There were errors if a page's last line is too long and needs to be
wrapped into two or more lines:
- The first line of the wrapped lines was printed correctly at the end of the page, but on the next page this first line was printed again.
- In print preview the first wrapped line was shown correctly at the end of the page, but the next and following pages were empty.
Reasons:
- remainder variable was always 0
- clipping was not reset
TEST PLAN
In Kate, open a text file that has long lines. Check lines at page ends
which are wrapped to the next page. Check printing and print preview.
REPOSITORY
R39 KTextEditor
BRANCH
fix_preview_and_printing
REVISION DETAIL
https://phabricator.kde.org/D21563
AFFECTED FILES
src/printing/printpainter.cpp
To: hoffmannrobert
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190603/ac176b89/attachment.html>
More information about the KWrite-Devel
mailing list