Default behaviour for including plugins

Christoph Cullmann christoph at
Fri Jul 26 20:07:19 BST 2019


On 2019-07-26 20:58, Daan De Meyer wrote:
> Alright, I can understand where you're coming from. However, I would
> then suggest we should apply the current approach consistently for
> each plugin by finding each plugin's dependencies in its CMake script
> and only building the plugin if all its dependencies are found. I'd
> move all the if tests and `set_package_properties` calls checks
> currently in addons/CMakeLists.txt to their respective plugin CMake
> scripts, leaving addons/CMakeLists.txt as a simple script only calling
> `ecm_add_optional_subdirectory` for each subdirectory in the addons
> directory. Each plugin CMake script then calls `find_package` to find
> its required dependencies and only continues with the rest of its
> script if all its dependencies are found.
> These changes should make plugin CMake scripts more consistent and
> localized which makes debugging and developing new plugins easier.

that would be ok for me.


Ignorance is bliss... |

More information about the KWrite-Devel mailing list