D22721: Clean up Kate addons CMake scripts.

[Daan De Meyer]

daandemeyer created this revision.
daandemeyer added a reviewer: Kate.
daandemeyer added a project: Kate.
Herald added a subscriber: kwrite-devel.
daandemeyer requested review of this revision.

REVISION SUMMARY
  This is the first in a series of revisions modernizing the Kate CMake scripts. 
  I'm submitting the changes to the addons directory first as they form a 
  nicely separated list of changes.
  
  Note that if https://phabricator.kde.org/D22698 and 
  https://phabricator.kde.org/D22699 are merged, most if not all of the
  remaining source lists in the addons directory can be removed in favor of
  working with targets.
  
  List of changes made:
  
  - Standardize style on two spaces and no whitespace between commands and
  
  arguments.
  
  - Remove directory commands in favor of target-based commands as
  
  recommended by modern CMake.
  
  - Remove usage of `qt5_add_resources` in favor of `CMAKE_AUTORCC` and
  
  adding .qrc files directly to a target's sources.
  
  - Remove usage of source lists (where possible) in favor of CMake 3.1's
  
  `target_sources` command.
  
  - Remove the CMake binary directory as an include directory from most
  
  addons.
  
  - Remove unnecessary comments, CMake project calls, config files, etc
  
  from addon CMake scripts.
  
  - Remove `HAVE_CTERMID` from config.h and move the check and addition
  
  to compile definitions to the project addon CMake script as its only
  used in the project plugin sources.

TEST PLAN
  Apply changes and verify Kate still builds and works exactly as before.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22721

AFFECTED FILES
  CMakeLists.txt
  addons/CMakeLists.txt
  addons/backtracebrowser/CMakeLists.txt
  addons/backtracebrowser/autotests/CMakeLists.txt
  addons/close-except-like/CMakeLists.txt
  addons/close-except-like/close_except_plugin.cpp
  addons/close-except-like/config.h.in
  addons/filebrowser/CMakeLists.txt
  addons/filetree/CMakeLists.txt
  addons/filetree/autotests/CMakeLists.txt
  addons/gdbplugin/CMakeLists.txt
  addons/kate-ctags/CMakeLists.txt
  addons/katebuild-plugin/CMakeLists.txt
  addons/katesql/CMakeLists.txt
  addons/konsole/CMakeLists.txt
  addons/lspclient/CMakeLists.txt
  addons/lspclient/tests/CMakeLists.txt
  addons/lumen/CMakeLists.txt
  addons/openheader/CMakeLists.txt
  addons/preview/CMakeLists.txt
  addons/project/CMakeLists.txt
  addons/project/autotests/CMakeLists.txt
  addons/project/kateprojectplugin.cpp
  addons/replicode/CMakeLists.txt
  addons/rustcompletion/CMakeLists.txt
  addons/search/CMakeLists.txt
  addons/sessionapplet/CMakeLists.txt
  addons/sessionapplet/engine/CMakeLists.txt
  addons/snippets/CMakeLists.txt
  addons/symbolviewer/CMakeLists.txt
  addons/tabswitcher/CMakeLists.txt
  addons/tabswitcher/autotests/CMakeLists.txt
  addons/tabswitcher/tests/CMakeLists.txt
  addons/textfilter/CMakeLists.txt
  addons/xmlcheck/CMakeLists.txt
  addons/xmltools/CMakeLists.txt
  config.h.cmake

To: daandemeyer, #kate
Cc: kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190724/51bd022e/attachment-0001.html>