christoph at cullmann.io
Wed Jul 24 14:01:00 BST 2019
On 2019-07-24 12:43, Daan De Meyer wrote:
> I agree that passing the version via the command line might be a bit
> excessive. However, by moving the other defines out of the config.h,
> we can only specify them for the targets that actually use them which
> feels like an improvement to me. I'll keep the config file to store
> the version but maybe it should be renamed to version.h to more
> accurately reflect its contents now.
Perhaps it would make sense to share the diff via phabricator to see
the current state and if the direction is ok.
> On Wed, 24 Jul 2019 at 11:23, Alex Turbov <i.zaufi at gmail.com> wrote:
>> On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer
>> <daan.j.demeyer at gmail.com> wrote:
>>> The KATE_VERSION variable was used in some source files but by
>>> passing the version as a command line define via CMake allowed me
>>> to remove the config.h file completely.
>> The good practice IMO is completely opposite: move `#defines` from
>> CLI to generated `*.h` file(s) as much as you can. As for me, it'll
>> make the CLI shorter and readable by humans w/ less pain. But the
>> main reason: various shells have different limitations on CI
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org
More information about the KWrite-Devel