CMake style

Alex Turbov i.zaufi at gmail.com
Wed Jul 24 10:23:04 BST 2019


Hi,

On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer <daan.j.demeyer at gmail.com>
wrote:

> The KATE_VERSION variable was used in some source files but by passing the
> version as a command line define via CMake allowed me to remove the
> config.h file completely.
>

 The good practice IMO is completely opposite: move `#defines` from CLI to
generated `*.h` file(s) as much as you can. As for me, it'll make the CLI
shorter and readable by humans w/ less pain. But the main reason: various
shells have different limitations on CI length...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190724/a45cb80d/attachment-0001.html>


More information about the KWrite-Devel mailing list