D22199: New plugin to open the selected file path

[Arnaud Ruiz]

nononux marked 2 inline comments as done.
nononux added inline comments.

INLINE COMMENTS

> dhaumann wrote in plugin_kateopenselection.cpp:80
> A PluginViewKateOpenSelection instance is created here for every KTextEditor::MainWindow - this is ok and works as designed / intended.
> 
> However, PluginViewKateOpenSelection inherits KTextEditor::Command, which itself registers in its constructor with the command "open-selection" in the Kate's command line. Now when you create multiple  MainWindows in Kate (View > New Window), then you will add *the same* "open-selection" command twice, which is wrong.
> 
> In short: PluginViewKateOpenSelection must not inherit KTextEditor::Command. Instead, the PluginKateOpenSelection should inherit it.

As a class cannot inherit from 2 QObjects, I've made another class included in the plugin as a member.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22199

To: nononux, dhaumann
Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad, fbampaloukas, domson, michaelh, ngraham, demsking, skadinna, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190721/ef53ad25/attachment.html>